Skip to content

If depicted Wikidata item has no associated Commons category property, then suggest categories from its P18 #6130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

savsch
Copy link
Contributor

@savsch savsch commented Jan 14, 2025

Description (required)

Resolves #5936

Tests performed (required)

Tested ProdDebug on Samsung S20FE with API level 33.

Screenshots (for UI changes only)
In the screenrecord below, the item Warnitz (Uckermark) railway station has no commons category, so its P18's categories are listed. On the other hand, the item human has a commons category, which is listed on the categories screen.

depict-categories.mp4

@savsch savsch marked this pull request as draft January 15, 2025 07:33
@savsch savsch marked this pull request as ready for review January 15, 2025 18:25
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks!

@nicolas-raoul nicolas-raoul merged commit 1e64acd into commons-app:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If depicted Wikidata item has no associated Commons category property, then suggest categories from its P18
2 participants