Skip to content

Fix crash when opening Leaderboard Tab #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

rohit9625
Copy link
Contributor

Description (required)

Fixes #6217

What changes did you make and why?
We were using the session manager from MainActivity to retrieve the username, despite having it in the ContributionsFragment. So, I refactor it to use its own class session manager property.

Tests performed (required)

Tested prodDebug on Samsung A14 with API level 34.

Screenshots (for UI changes only)
None

@rohit9625 rohit9625 force-pushed the fix/leaderboard-crash branch from 7c58ac8 to c4874f2 Compare March 3, 2025 12:50
Copy link

github-actions bot commented Mar 3, 2025

✅ Generated APK variants!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the crash, now leaderboard shows correctly.
Thanks a lot Rohit and sorry for the delay! :-)

@nicolas-raoul nicolas-raoul merged commit 681881f into commons-app:main Mar 6, 2025
1 check passed
@rohit9625 rohit9625 deleted the fix/leaderboard-crash branch March 9, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducible crash when tapping on "Leaderboard" tab
2 participants