Skip to content

Fix : UninitializedPropertyAccessException #6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sonalyadav1
Copy link
Contributor

Description (required)

When a user uploads a file with a name that already exists, they get a warning about the duplicate file. Clicking "Upload" after this caused a crash.

Fixes #6247

What changes did you make and why?

(1) Fixed crash when uploading after a duplicate filename warning by adding proper checks and error handling.

(2) Ensured the warning message displays correctly and does not interfere with the upload process.

Tests performed (required)

Tested {build variant (BetaDebug)} on {VIVO V25} with API level {34}.

Screenshots (for UI changes only)

Screenrecording_20250314_201059.mp4

Copy link

✅ Generated APK variants!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I still get the same crash with this branch...

@nicolas-raoul
Copy link
Member

screen-20250315-211239.mp4

@sonalyadav1
Copy link
Contributor Author

I tested the same branch on my end, but I’m not experiencing the crash.😓

@psh
Copy link
Collaborator

psh commented Mar 17, 2025

If I read the code correctly, you've only swapped an UninitializedPropertyAccessException for an IllegalStateException without addressing the root cause of why it might be throwing any kind of exception in the first place?

@sonalyadav1
Copy link
Contributor Author

@psh You're absolutely right—swapping exceptions doesn’t address the root cause. My initial approach was incomplete, and I appreciate you pointing that out.

@misaochan
Copy link
Member

Hi @sonalyadav1 , are you still working on this?

@sonalyadav1
Copy link
Contributor Author

@misaochan Due to ongoing university practicals and exams, my availability is limited at the moment. However, I’ll do my best to resolve the issue shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants