Skip to content

ui: make recenter FAB theme-aware using Material attributes #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025

Conversation

samimshoaib01
Copy link
Contributor

@samimshoaib01 samimshoaib01 commented Apr 11, 2025

Fixes:#6267

Updated the FloatingActionButton to use theme-aware attributes for background (?attr/colorSurface) and icon tint (?attr/colorOnSurface). This improves visual consistency and readability across light and dark themes, addressing poor visibility of the icon in dark mode.

This change follows Material Design guidelines and removes hardcoded values to ensure the FAB dynamically adapts to the app's current theme.

Currently it look's like this:
image

Copy link

✅ Generated APK variants!

Copy link
Collaborator

@RitikaPahwa4444 RitikaPahwa4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@RitikaPahwa4444 RitikaPahwa4444 merged commit 6aeb3c0 into commons-app:main Apr 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants