Fix: Show captions instead of filenames in Explore > Map (Fixes #6294) #6299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Apr 29, 2025
app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapController.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt
Show resolved
Hide resolved
|
Hi @nicolas-raoul, |
nicolas-raoul
requested changes
Apr 29, 2025
| public LatLng latestSearchLocation; // Last search center | ||
| public LatLng currentLocation; // User’s current location | ||
| public double latestSearchRadius = 0; // Last search radius | ||
| public double currentLocationSearchRadius = 0; // Radius when searching around current location |
There was a problem hiding this comment.
Would you mind including only changes that are relevant to the issue at hand? Thanks!
|
Hi Rajas, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6294
What changes did you make and why?
Updated the Explore > Map view to display the caption (in the user's language) instead of the filename on green pins.
If a caption is unavailable, the app falls back to showing the filename.
Improves usability and localization, matching the behavior in Explore > Featured.
Tests performed (required)
Tested ProdDebug build variant on Medium Emulator (API 36) and Pixel 7 Emulator (API 34).
Verified:
Captions appear correctly on green pins when available.
Filenames are shown when captions are missing.
Clicking pins opens the bottom sheet without crashes.
Behavior verified even when some media items lack captions.
Screenshots (for UI changes only)
No UI layout changes.
Only the text label of the green pins was updated based on available captions.