Fix/upload limit #3101 #6500
Open
Fix/upload limit #3101 #6500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated warning dialog strings, and ensured thumbnail bar consistency
nicolas-raoul
requested changes
Oct 14, 2025
app/src/main/java/fr/free/nrw/commons/customselector/ui/adapter/ImageAdapter.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@nicolas-raoul Changed from 5 image limit to 20 image limit as per #3101 (comment) |
nicolas-raoul
requested changes
Oct 14, 2025
app/src/main/java/fr/free/nrw/commons/customselector/ui/adapter/ImageAdapter.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@nicolas-raoul - Made the required changes. |
Member
|
I am travelling (now Hyderabad) so I can't test, but I hope I will be able to do it on Wednesday. Or someone might do it before me. Thank you for your understanding! 🙂 |
Collaborator
Author
Oh, Hyderabad! Wishing you a pleasant journey. I hope you get the chance to explore and enjoy the beauty of the city. |
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3101
Implemented a strict 20-image selection and upload limit in the Wikimedia Commons app to prevent server overload and align with user feedback. Modified
CustomSelectorActivity.ktandImageAdapter.ktto restrict selection to 5 images, updatedUploadActivity.ktto process only 5 images, added a close button initem_custom_selector_image.xmlfor deselection, updatedcustom_selector_limit_dialog.xmlandstrings.xmlfor a clear 5-image limit message, and ensuredThumbnailsAdapter.ktdisplays only 5 images in the upload UI thumbnail bar.