-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix title hidden and inaccessible in scroll if descriptions is long issue #6537 #6585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix title hidden and inaccessible in scroll if descriptions is long issue #6537 #6585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also post a "before" screencast showing the bug? Thanks!
For me the app with this pull request is working fine, but I was not experiencing the bug before either.
Posted the screencast which was showing the bug, Where we can't access the edit image and location button when the image preview is expanded. And after a long description the caption field is also getting inaccessible. |
|
Haven't tested after the clean up (last commit) but I was able to scroll through. Just curious: any idea why adjustPan is no longer helping on this screen and what if happens when the screen gets rotated? |
|
✅ Generated APK variants! |
|
Thanks for checking it. The main reason adjustPan wasn’t helping here is that the problem wasn’t really the keyboard, it was how the layout was structured. When the thumbnails card expanded, it pushed the ViewPager down, because it was inside a RelativeLayout with match_parent height, there wasn’t any flexible space left for the system to work with. So from android's point of view nothing could move and adjustPan had no effect. By switching the container to a vertical LinearLayout and giving the ViewPager a layout_weight,the screen now has a clear flexible area. That lets Android shrink the ViewPager when the top card expands or when the keyboard appears, instead of pushing the caption field offscreen which is why scrolling starts working again. Regarding rotation,since the ViewPager always fills whatever space is left after the top card, the layout adapts cleanly in both portrait and landscape. The thumbnails still have a capped height and the caption field stays reachable after rotation. |
|
Actually it started happening after we added support for edge to edge, so the layout worked as intended as per my understanding. But this can definitely be another way to approach the problem, so I'll start testing and reviewing :) |
|
Yeah,Ig those e to e changes reduced the usable height of the screen, so when the thumbnails expand, the layout doesn’t have enough room and the caption field gets pushed offscreen instead of staying scrollable. Thanks a lot for testing it really appreciate it.If you notice anything weird during rotation or other cases I’m happy to take another look and adjust it ig. |
Description
Fixed the issue where the Caption field becomes inaccessible when the image preview thumbnails are expanded in the upload flow. Users can now scroll to access all input fields regardless of thumbnail expansion state.
Changes Made
activity_upload.xmlroot layout fromRelativeLayouttoLinearLayoutwith vertical orientationmaxHeight="120dp"torv_thumbnailsRecyclerView to limit thumbnail expansionnestedScrollingEnabled="false"torv_thumbnailsto prevent scroll conflictslayout_weight="1"with0dpheight for proper space distributionRoot Cause
When the top card's thumbnail RecyclerView expanded, it pushed the ViewPager containing the upload details off-screen. The unlimited height of the thumbnail section caused the Caption field to become inaccessible.
Solution
Limited the thumbnail RecyclerView height and restructured the layout to properly distribute available space between the thumbnail section and the detail fragment.
Testing
Fixes
Closes #6537
Screen Recording
Reproduced Bug
https://github.com/user-attachments/assets/f90b5c5d-989f-4548-943c-79f9d185da59
Fixed after the changes made
https://github.com/user-attachments/assets/5d1111b4-a7be-4ebd-81da-741bdcd29cf2