Testing nav drawer #661
Testing nav drawer #661
Conversation
|
@misaochan there are some changes to the gradle file which is added to enable espresso ui testing. Please check whether this does not affect any other tests. |
|
changes related to #586 |
| @@ -24,7 +24,15 @@ dependencies { | |||
|
|
|||
| testCompile 'junit:junit:4.12' | |||
| androidTestCompile "com.android.support:support-annotations:${project.supportLibVersion}" | |||
| androidTestCompile 'com.android.support.test.espresso:espresso-core:2.2.2' | |||
| // androidTestCompile 'com.android.support.test.espresso:espresso-core:2.2.2' | |||
|
|
|||
There was a problem hiding this comment.
Why would you comment it out? It can probably be removed (if it is a dependency to espresso-contrib).
| .perform(open()); | ||
|
|
||
| //test the settings fragment is displayed | ||
| onView(withId(R.id.settings_item)).perform(click()); |
There was a problem hiding this comment.
This causes "Error:(40, 27) error: cannot find symbol variable settings_item", if you rebase master. After some recent changes around the drawer, this patch seems to need some revision.
|
@sandarumk Sorry for not coming back to this earlier, but it looks like in the meantime some changes affecting the drawer made the patch obsolete. I do love the idea of having a test for it. Perhaps you might want to drop this and make a fresh try later. Of course, you are welcome to amend it to accomodate the changes, if you prefer that way. https://www.codacy.com/app/domdomegg/apps-android-commons/pullRequest?prid=661305 has some suggestion about coding style, too. |
|
If there won't be any revisions ,n a few days, I think we can close this PR. |
|
Agreed, closing. Thanks all! |
Few tests are added to test the navigation drawer which is newly implemented