fix : leaks at Media Detail Fragment

[rovertrack]

Fixes #6692

What changes did you make and why?

MediaDetailAdapter.kt

• guard to make sure mediaDetailPagerFragment is not access after removal

MediaDetailFragment.kt

• Replaced OnGlobalLayoutListener with doOnNextLayout for autocleanup
• Introduced a fragmentHandler to clear callbacks on onDestroyView()
• Nullifies _binding and media image view controller to avoid leaks

MediaDetailPagerFragment.kt

• binding = null and adapter = null in onDestroyView().
• Uses CompositeDisposable to prevent RxJava leaks.
• Uses binding.itemProgressBar instead of findViewById as it is access only once to avoid cleanup

MediaDetailFragmentUnitTests.kt

• Removed layoutListener mock testing since the obsolete OnGlobalLayoutListener was removed

Screenshots (for UI changes only)

VID_20260305004734.mp4

[rovertrack]

@neeldoshii i have fixed leaks around Media Detail Fragment & Contribution Fragment
and many more which i encountered while fixing and testing the app
i think it solves most of the leaks persisting
please test it and let me know if it solves the issue )

[neeldoshii]

Hi @rovertrack, thanks for working on the memory leaks! Would it be possible to keep each PR focused on a specific leak or file? It’s a bit hard to review when it mentions “many more which I encountered.”

Instead, could you provide specific details about each leak you're solving? That would make it much easier to review and understand the RCA. Also, it would help if each PR focuses on solving one issue at a time.

Feel free to split them into multiple PRs (one per memory leak) if that works better. It will make them easier to review and maintain. :-)

[rovertrack]

@neeldoshii i have separated the PRs for separate leaks as follow up for this PR

[RitikaPahwa4444]

Sorry, I haven't read the entire code, but just to confirm once, this line addresses the issue I mentioned in this PR: #6624, is it? 🙂

We'll test it a bit intensively as we've seen regressions in at least two PRs. Thanks for your patience.

[rovertrack]

mostly yes , because many cases it tries to access that pager after destroyed which results in ANR ,null pointer

sure , anything as long as it solves the issue )

[rovertrack]

@RitikaPahwa4444 is this pr good ? As far as I have tested it solved the leaks !

[github-actions]

✅ Generated APK variants!

• 🤖 Download prodDebugAPK
• 🤖 Download betaDebugAPK