Fix #6680: Bump Target SDK to API Level 36#6712
Open
MohamedMBG wants to merge 1 commit intocommons-app:mainfrom
Open
Fix #6680: Bump Target SDK to API Level 36#6712MohamedMBG wants to merge 1 commit intocommons-app:mainfrom
MohamedMBG wants to merge 1 commit intocommons-app:mainfrom
Conversation
- Updated `compileSdk` and `targetSdk` to 36 in [app/build.gradle.kts](cci:7://file:///c:/Users/pc/projectw/apps-android-commons/app/build.gradle.kts:0:0-0:0) to meet the new API level requirements. - Added `android:enableOnBackInvokedCallback="false"` to the `<application>` tag in [AndroidManifest.xml](cci:7://file:///c:/Users/pc/projectw/apps-android-commons/app/src/main/AndroidManifest.xml:0:0-0:0) as a minimal, temporary opt-out for predictive back navigation. This ensures the app's existing legacy `onBackPressed()` handling continues to function correctly without requiring a broad migration at this time.
Collaborator
|
Hi @MohamedMBG, @rohit9625 had already expressed his interest to work on this issue. We suggest asking to be assigned instead of raising PRs directly to prevent redundant effort. Although it was a miss on our part to agree but not assign it officially, it was implicit from the discussion that Rohit was working on it. Kindly refrain from skipping the process and comment once to confirm if the issue is up for grab. Thanks for your understanding! 🙂 |
Collaborator
|
Hi @MohamedMBG, Thanks for contributing, seems like some unit tests are failing. Can you have a look at it once? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #6680 by updating the project to compile and target Android API Level 36 doing only the minimal necessary changes.
Changes Made:
compileSdkandtargetSdkto36in app/build.gradle.kts.android:enableOnBackInvokedCallback="false"back-navigation opt-out to AndroidManifest.xml. Since the app relies heavily on legacyonBackPressed()for navigation, this temporarily opts out of the predictive back behavior introduced/enforced in newer SDKs, allowing the app to compile and run normally on SDK 36 without undergoing an immediate, full-scale navigation rewrite.Scope Confirmation:
Fixes #6680