fix : alignment nearby list item

[rovertrack]

Fixes alignment of items in nearby list view

What changes did you make and why?
added proper margin and padding to items

Screenshots (for UI changes only)
Before :

After :

[amahuli03]

Review by GSoC applicant

I was able to reproduce the issue by navigating to the nearby list:

As you can see, the icons to the left are not aligned with each other or with the text.

After pulling @rovertrack's changes, I repeated the steps from earlier and could see the changes visually:

The original issue (mis-aligned images and text in the nearby list) was successfully addressed with this PR!

I did find one issue with these changes after looking into how LinearLayout works. This PR changes the root of item_place.xml from a RelativeLayout to a LinearLayout, which stacks its children top to bottom on its own. RelativeLayout uses android:layout_below="@+id/icon" to position siblings. layout_below is an attribute of RelativeLayout.LayoutParams. Now, we use LinearLayout, which does not recognize layout_below and silently skips it.

To avoid confusion, you should remove android:layout_below="@+id/icon" entirely. I tested this, and the page renders the same (with the proper alignment we want). That line makes no difference since it is dead code.

[rovertrack]

@amahuli03 thank you very much for the review .
the dead code was present from the main branch ( inside a linear layout ) , to keep the changes minimal i had not touched that thanks for pointing out

[github-actions]

✅ Generated APK variants!

• 🤖 Download prodDebugAPK
• 🤖 Download betaDebugAPK