Skip to content

Fix: Info icon distortion#6737

Open
Roniscend wants to merge 1 commit intocommons-app:mainfrom
Roniscend:Fix-icon
Open

Fix: Info icon distortion#6737
Roniscend wants to merge 1 commit intocommons-app:mainfrom
Roniscend:Fix-icon

Conversation

@Roniscend
Copy link
Contributor

@Roniscend Roniscend commented Mar 15, 2026

Description (required)

Fixes #6699
Wrapped FABs in a vertical LinearLayout to fix icon distortion and alignment issues in landscape mode.

Tested 6.3.0-debug on Pixel 9 (Android 16)

Screenshots (for UI changes only)
c
d

Signed-off-by: Owm Dubey <owmdubey163@gmail.com>
Copilot AI review requested due to automatic review settings March 15, 2026 12:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Nearby map UI layout to group the “recenter” and “legend” FloatingActionButtons into a single vertically-stacked container, simplifying positioning and spacing within the parent RelativeLayout.

Changes:

  • Removed individually-positioned fab_recenter / fab_legend definitions.
  • Reintroduced those FABs inside a new vertical LinearLayout aligned to the end of the map area.
  • Updated margins/spacing by moving common positioning to the container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

✅ Generated APK variants!

@RitikaPahwa4444
Copy link
Collaborator

We have FABs nested inside a LinearLayout and not CoordinatorLayout explicitly used as mentioned in the PR description. Is this understanding correct?

@Roniscend
Copy link
Contributor Author

We have FABs nested inside a LinearLayout and not CoordinatorLayout explicitly used as mentioned in the PR description. Is this understanding correct?

Yes, you are absolutely correct, and I have updated the PR description to reflect the use of LinearLayout.

@RitikaPahwa4444
Copy link
Collaborator

RitikaPahwa4444 commented Mar 15, 2026

I'll test it in some time, although I'm expecting linear layout to fix the issue :)

@Roniscend
Copy link
Contributor Author

I'll test it in some time, although I'm expecting linear layout to fix the issue :)

Sure , Thanks :)

@RitikaPahwa4444
Copy link
Collaborator

By the way, curious to know about the other approach you'd mentioned: did you try anchoring as well?

@Roniscend
Copy link
Contributor Author

By the way, curious to know about the other approach you'd mentioned: did you try anchoring as well?

It was not working properly hence the other approach

@Akul-Tyagi
Copy link
Contributor

Review by GSoC Applicant

I reproduced the issue from main on my device by increasing system font size (largest setting), navigating to Nearby, and rotating to landscape.
Result before this PR: the info (i) FAB appears visually distorted / non-circular.

Before applying changes:

Screen_Recording_20260319_215515_Commons.mp4

Screenshot_20260319_204436_Commons

I then pulled this PR branch (Fix-icon), built the betaDebug variant, and tested with the exact same steps.
Result after this PR: the info FAB keeps its circular shape, and alignment between the recenter and info FABs is consistent in landscape.

After applying changes:

Screen_Recording_20260319_215612_Commons.mp4

Screenshot_20260319_210852_Commons

What I checked:

  • Landscape with large font (repro condition)
  • Return to portrait behavior
  • Tap behavior/hitboxes of both FABs (recenter + legend/info)

The reported issue is resolved with this PR. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Info (i) icon loses circular shape in landscape mode

4 participants