Skip to content

Fix location handling for gallery uploads in Nearby flow #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devendrachoudharycodes wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Fix location handling for gallery uploads in Nearby flow #6739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,10 +1002,15 @@ class UploadActivity : BaseActivity(), UploadContract.View, UploadBaseFragment.C
Manage EXIF Tags setting or turned "Record location for in-app shots" off.
Also, location information is discarded if the difference between
current location and location recorded just before capturing the image
is greater than 100 meters */
if (isLocationTagUnchecked || locationDifference > 100
is greater than 100 meters
NOTE:- The LOCATION_BEFORE_IMAGE_CAPTURE is only available
for in-app camera uploads. For gallery uploads, this location is not
passed via the intent from Nearby to UploadActivity. Therefore,
the location difference check should only apply to camera uploads.
*/
if (isLocationTagUnchecked
|| !defaultKvStore.getBoolean("inAppCameraLocationPref")
|| !isInAppCameraUpload
|| (isInAppCameraUpload && locationDifference > 100)
) {
currLocation = null
}
Expand Down
Loading