Fix keyboard covering screen after rotation on Nearby screen#6740
Open
Roniscend wants to merge 1 commit intocommons-app:mainfrom
Open
Fix keyboard covering screen after rotation on Nearby screen#6740Roniscend wants to merge 1 commit intocommons-app:mainfrom
Roniscend wants to merge 1 commit intocommons-app:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Nearby screen landscape rotation case where the IME/keyboard obscures most of the UI, improving search usability after rotation.
Changes:
- Center the Nearby filter list container horizontally in the Nearby parent layout (and related included layout).
- Disable IME “extract UI” for the Nearby
SearchViewto keep typed text visible in landscape. - Set
MainActivitysoft input mode toadjustResizeto better accommodate the keyboard.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/res/layout/nearby_filter_list.xml | Adjusts layout positioning attribute on the included filter list root. |
| app/src/main/res/layout/fragment_nearby_parent.xml | Centers the included filter list container horizontally within the Nearby screen. |
| app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt | Updates SearchView IME options to avoid extract/fullscreen behavior in landscape. |
| app/src/main/AndroidManifest.xml | Applies adjustResize to MainActivity to resize content when the keyboard is shown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Owm Dubey <owmdubey163@gmail.com>
|
✅ Generated APK variants! |
Contributor
Author
|
@nicolas-raoul can you review this pr and suggest changes if any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6701
Resolves an issue where the keyboard covered most of the screen in landscape mode on the Nearby screen
Tested 6.3.0-debug on Pixel 9 (Android 16)
Screenshots (for UI changes only)
Before
After
The text entered by the user is now visible