Skip to content

Add a marker and circle of accuracy for current location #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2017

Conversation

tobias47n9e
Copy link
Member

Currently the user's position is not visible on the map. This
commit adds a marker to the user's position and a circular
polygon which shows the accuracy of the location measurement.

screenshot from 2017-05-28 17-41-05

Currently the user's position is not visible on the map. This
commit adds a marker to the user's position and a circular
polygon which shows the accuracy of the location measurement.
@codecov-io
Copy link

Codecov Report

Merging #692 into master will decrease coverage by 0.09%.
The diff coverage is 16.32%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #692     +/-   ##
=======================================
- Coverage     6.1%     6%   -0.1%     
=======================================
  Files          88     94      +6     
  Lines        4885   5012    +127     
  Branches      439    444      +5     
=======================================
+ Hits          298    301      +3     
- Misses       4562   4686    +124     
  Partials       25     25
Impacted Files Coverage Δ
.../fr/free/nrw/commons/nearby/NearbyMapFragment.java 0% <0%> (ø) ⬆️
...e/nrw/commons/location/LocationServiceManager.java 37.14% <0%> (-3.49%) ⬇️
...a/fr/free/nrw/commons/nearby/NearbyInfoDialog.java 0% <0%> (ø) ⬆️
.../java/fr/free/nrw/commons/nearby/NearbyPlaces.java 0% <0%> (ø) ⬆️
...a/fr/free/nrw/commons/nearby/NearbyController.java 19.56% <0%> (-0.89%) ⬇️
...n/java/fr/free/nrw/commons/MediaDataExtractor.java 0% <0%> (ø) ⬆️
...fr/free/nrw/commons/nearby/NearbyListFragment.java 75.67% <0%> (ø) ⬆️
...in/java/fr/free/nrw/commons/utils/LengthUtils.java 84.21% <100%> (ø) ⬆️
...main/java/fr/free/nrw/commons/location/LatLng.java 54.28% <80%> (+2.67%) ⬆️
...w/commons/contributions/ContributionsActivity.java 0% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b400cd...4dbf9d0. Read the comment docs.

@misaochan misaochan merged commit 8104556 into commons-app:master May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants