Skip to content

fix for #733,732 issue #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2017
Merged

fix for #733,732 issue #768

merged 1 commit into from
Jul 11, 2017

Conversation

tised
Copy link
Contributor

@tised tised commented Jul 10, 2017

fix for:

The problem is that onCreate of content resolver are calling before even Apllication onCreate, so that fields may be null which caused crashes

The problem is that onCreate of content resolver are calling before even Apllication onCreate, so that fields may be null which caused crashes
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@31b12ba). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #768   +/-   ##
========================================
  Coverage          ?   6.14%           
========================================
  Files             ?      93           
  Lines             ?    5045           
  Branches          ?     455           
========================================
  Hits              ?     310           
  Misses            ?    4709           
  Partials          ?      26
Impacted Files Coverage Δ
...ns/modifications/ModificationsContentProvider.java 11.11% <0%> (ø)
...ns/contributions/ContributionsContentProvider.java 10% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b12ba...8697909. Read the comment docs.

Copy link
Member

@misaochan misaochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Whoops, sorry. The bug I found was not connected with your PR. :)

@misaochan misaochan merged commit 691acbf into commons-app:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants