Skip to content

Fixed issue #894 #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Fixed issue #894 #952

merged 1 commit into from
Nov 21, 2017

Conversation

JohnKal
Copy link
Contributor

@JohnKal JohnKal commented Nov 12, 2017

This line solves the problem with the device rotation.

@codecov-io
Copy link

Codecov Report

Merging #952 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #952      +/-   ##
=========================================
- Coverage    6.44%   6.43%   -0.01%     
=========================================
  Files          97      97              
  Lines        5201    5202       +1     
  Branches      488     488              
=========================================
  Hits          335     335              
- Misses       4838    4839       +1     
  Partials       28      28
Impacted Files Coverage Δ
...w/commons/contributions/ContributionsActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c568f81...8dc9103. Read the comment docs.

@neslihanturan
Copy link
Collaborator

I tested it and yes, it solves the problem. But, on rotation moment contribution list appears and disapears very fast. Since it is very fast I couldn't get screen shots. Did you see that @JohnKal ?

@JohnKal
Copy link
Contributor Author

JohnKal commented Nov 18, 2017

@neslihanturan yes i see it now. If it is a problem i will try to fix it.

@neslihanturan
Copy link
Collaborator

@misaochan and @maskaravivek , I think we should prioritize this one also before release. What do you think about merging this PR?

@misaochan
Copy link
Member

Yeah, sounds good to me. We can create a new issue for the appearing/disappearing if needed.

@misaochan misaochan merged commit 591575f into commons-app:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants