Fix issues around location in nearby activity #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be fixing #978 after this is merged. |
misaochan
reviewed
Dec 1, 2017
| } | ||
|
|
||
| // private void turnGPSOn(Context context){ |
There was a problem hiding this comment.
Could I ask why this block is commented out?
There was a problem hiding this comment.
I was trying out something. It doesn't matter now. We have @psh's test to replace ours.
|
Thanks for submitting this, @maskaravivek ! I'm hoping to test it this weekend if I can, and then maybe we could include it in our release (planned for early next week). Some conflicts need to be resolved though, after the recent test PR merge. |
misaochan
approved these changes
Dec 2, 2017
|
Tested this on real device running Android 7.0 and works well for me. Happy to merge once conflicts are resolved. :) |
f5f00e0 to
b9b906e
Compare
|
@misaochan I have rebased the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce?
The above issue is now fixed.
How do you know?
The above should be hopefully fixed.
The app now stops listening for location updates as soon as the nearby list is populated.
It again registers the location manager when the refresh button is clicked.
App now uses multiple providers to fetch the location.
Why?
GPS_PROVIDERis usually slower. Now the app would be using bothNETWORK_PROVIDERfor coarse location andGPS_PROVIDERfor finer location. Upon receiving a location update, it will determine if the newer location is better than the last location. If it is, the newer location would be used.Also fixes #982.