-
Notifications
You must be signed in to change notification settings - Fork 29
Revamp screen shots for release v2.10.2 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes commons-app#11. Some images are kept without being used just in case they are needed in future.
This would help the users quickly identify the new features and become aware of them.
df6473e
to
f8c2ac3
Compare
Looks great! Title: Woman working in rice field in Khoria, Uttar Pradesh ... or something similar, because I just made that up. |
Further emphasize that an account is not needed to epxlore commons to clarify to people who might be in a confusion as to whether an account is required or not.
The title/description has been updated to be more detailed as suggested by @nicolas-raoul.
This resolves one of the items in commons-app#19.
I've made the change you have suggested @nicolas-raoul. Also, I've made some other fixes. Please review and let me know if we could merge this. It would be nice if you could also take a look at #37 which is a minor improvement. Merging it would make the sites text font more appealing, IMO. |
Some more feedback (sorry for not providing earlier):
|
The Rosemary looks nice but might not suit well for the website. So, update the screenshots to use the default system font. While at it, remove the unused and obsolete screen shots. Also, highlight the feature that shows ongoing campaigs to users in the home page.
This is to correctly attribute the author of the image featured in one of the uplaod screenshots. Image source: https://commons.wikimedia.org/wiki/File:Farm_Life_Village_India.jpg
That's a good point 🙂 I actually noted that I've forgot to switch fonts only after taking the screen shots and was lazy to take them again and left it unchanged for someone to point out. Since you've pointed it out, I've changed the screen shots. As a bonus, it was also possible to feature the ongoing campaigns 😉
I'll file a bug for that. For now, I think of using the screen shot as it is (after the updated font) for now. What do you think? Should we remove that section?
I've attributed the photo of the women working in the paddy field (it shows up on hovering over the corresponding image). Should we have to attribute those in the explore/search features too? |
Just for the note, the page is still live at https://sivaraam.github.io/commons-app.github.io/ |
Keep it for now. We can always take more screenshots when this is resolved.
Yeah, we should attribute the others. Also it might be an idea to make the attribution more prominent, I don't know how though. Alternatively it might be good if we could find PD images so attribution is not necessary (but do keep the attribution in the alt attribute for good practice) |
Just for the sake of clarity, do you want me to include the attribution in the 'alt' attribute too? Currently, I've just mentioned in the 'title' attribute. Also, I'm not sure including it in the 'alt' makes sense as the text in it would be displayed only when it is not possible to show the corresponding image. |
Whoops sorry, yeah I meant the title attribute. |
As of now, most of the images have been attributed.
48552e1
to
278127a
Compare
I've attributed most of the images. Let me know if I've missed something and if there's anything else left here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@domdomegg Thanks for reviewing! It was very useful 🙂 |
Fixes #11.
Some images are kept without being used just in case they are needed in
future.
Notes
This is my first attempt at trying to revamp the screen shots. Let me know if they are OK. They could be seen live at https://sivaraam.github.io/commons-app.github.io/
Question: Can the explore feature be used just to discover images? Or can it be used to discover other kind of media such as audio, video etc.? I was only able to see images in Explore for my searches.