Skip to content

Revamp screen shots for release v2.10.2 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 6, 2019

Conversation

sivaraam
Copy link
Member

Fixes #11.

Some images are kept without being used just in case they are needed in
future.

Notes

This is my first attempt at trying to revamp the screen shots. Let me know if they are OK. They could be seen live at https://sivaraam.github.io/commons-app.github.io/

Question: Can the explore feature be used just to discover images? Or can it be used to discover other kind of media such as audio, video etc.? I was only able to see images in Explore for my searches.

Fixes commons-app#11.

Some images are kept without being used just in case they are needed in
future.
This would help the users quickly identify the new features and become
aware of them.
@sivaraam sivaraam force-pushed the update-screenshots branch from df6473e to f8c2ac3 Compare March 31, 2019 17:43
@nicolas-raoul
Copy link
Member

Looks great!
I would just change the wording of the title/description image to something much more specific, for instance:

Title: Woman working in rice field in Khoria, Uttar Pradesh
Description: Picture taken between drainage and harvest. The woman wears a blue and pink dress typical of Khoria

... or something similar, because I just made that up.
This is important, to show users they should enter very meaningful and precise information :-)

sivaraam added 6 commits April 7, 2019 16:29
Further emphasize that an account is not needed to epxlore commons
to clarify to people who might be in a confusion as to whether an
account is required or not.
The title/description has been updated to be more detailed
as suggested by @nicolas-raoul.
This resolves one of the items in commons-app#19.
@sivaraam sivaraam self-assigned this Apr 7, 2019
@sivaraam
Copy link
Member Author

sivaraam commented Apr 7, 2019

I've made the change you have suggested @nicolas-raoul.

Also, I've made some other fixes. Please review and let me know if we could merge this. It would be nice if you could also take a look at #37 which is a minor improvement. Merging it would make the sites text font more appealing, IMO.

@domdomegg
Copy link
Member

Some more feedback (sorry for not providing earlier):

  • Use the default Android font (Roboto) instead of what I believe is Rosemary. I think it looks cleaner and more professional for the site. This is just my own personal view and is probably a matter of style up for debate though, so feel free to ignore if you prefer :)
  • Investigate why the app bar text seems to have a load of padding to the left. In the search activity this is extreme, 'flowers' is practically centred! This is probably a bug, would be good to open an issue if so.
  • Ensure all the photographs in the screenshots are licensed properly (e.g. the woman working in the paddy fields, and the ones in explore might have attribution requirements)

sivaraam added 2 commits May 2, 2019 01:33
The Rosemary looks nice but might not suit well for the website.
So, update the screenshots to use the default system font.

While at it, remove the unused and obsolete screen shots. Also,
highlight the feature that shows ongoing campaigs to users in the
home page.
This is to correctly attribute the author of the image featured in
one of the uplaod screenshots.

Image source: https://commons.wikimedia.org/wiki/File:Farm_Life_Village_India.jpg
@sivaraam
Copy link
Member Author

sivaraam commented May 1, 2019

Some more feedback (sorry for not providing earlier):

* Use the default Android font (Roboto) instead of what I believe is Rosemary. I think it looks cleaner and more professional for the site. This is just my own personal view and is probably a matter of style up for debate though, so feel free to ignore if you prefer :)

That's a good point 🙂 I actually noted that I've forgot to switch fonts only after taking the screen shots and was lazy to take them again and left it unchanged for someone to point out. Since you've pointed it out, I've changed the screen shots. As a bonus, it was also possible to feature the ongoing campaigns 😉

* Investigate why the app bar text seems to have a load of padding to the left. In the search activity this is extreme, 'flowers' is practically centred! This is probably a bug, would be good to open an issue if so.

I'll file a bug for that. For now, I think of using the screen shot as it is (after the updated font) for now. What do you think? Should we remove that section?

* Ensure all the photographs in the screenshots are licensed properly (e.g. the woman working in the paddy fields, and the ones in explore might have attribution requirements)

I've attributed the photo of the women working in the paddy field (it shows up on hovering over the corresponding image). Should we have to attribute those in the explore/search features too?

@sivaraam
Copy link
Member Author

sivaraam commented May 1, 2019

Just for the note, the page is still live at https://sivaraam.github.io/commons-app.github.io/

@domdomegg
Copy link
Member

* Investigate why the app bar text seems to have a load of padding to the left. In the search activity this is extreme, 'flowers' is practically centred! This is probably a bug, would be good to open an issue if so.

I'll file a bug for that. For now, I think of using the screen shot as it is (after the updated font) for now. What do you think? Should we remove that section?

Keep it for now. We can always take more screenshots when this is resolved.

* Ensure all the photographs in the screenshots are licensed properly (e.g. the woman working in the paddy fields, and the ones in explore might have attribution requirements)

I've attributed the photo of the women working in the paddy field (it shows up on hovering over the corresponding image). Should we have to attribute those in the explore/search features too?

Yeah, we should attribute the others. Also it might be an idea to make the attribution more prominent, I don't know how though. Alternatively it might be good if we could find PD images so attribution is not necessary (but do keep the attribution in the alt attribute for good practice)

@sivaraam
Copy link
Member Author

sivaraam commented May 2, 2019

(but do keep the attribution in the alt attribute for good practice)

Just for the sake of clarity, do you want me to include the attribution in the 'alt' attribute too? Currently, I've just mentioned in the 'title' attribute. Also, I'm not sure including it in the 'alt' makes sense as the text in it would be displayed only when it is not possible to show the corresponding image.

@domdomegg
Copy link
Member

Just for the sake of clarity, do you want me to include the attribution in the 'alt' attribute too? Currently, I've just mentioned in the 'title' attribute. Also, I'm not sure including it in the 'alt' makes sense as the text in it would be displayed only when it is not possible to show the corresponding image.

Whoops sorry, yeah I meant the title attribute.

As of now, most of the images have been attributed.
@sivaraam sivaraam force-pushed the update-screenshots branch from 48552e1 to 278127a Compare May 5, 2019 19:58
@sivaraam
Copy link
Member Author

sivaraam commented May 5, 2019

I've attributed most of the images. Let me know if I've missed something and if there's anything else left here.

Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sivaraam sivaraam merged commit a4ada56 into commons-app:master May 6, 2019
@sivaraam
Copy link
Member Author

sivaraam commented May 6, 2019

@domdomegg Thanks for reviewing! It was very useful 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New screenshot of nearby places with icons
3 participants