-
Notifications
You must be signed in to change notification settings - Fork 29
Added dark mode support #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for the PR! A few comments: Card shadowThe shadow for the cards don't seem visible in dark mode. Could you look into possibility of tweaking them ? Toggle icon sizeAlso, the toggle icon seems rather small. Would it be possible for you to use an icon that's easily noticeable. For example, the icons used by Docusaurus seem good. Dark mode friendly coloursThe blue, green and red in the page could be replaced with their dark mode friendly variants in dark mode. Could you look into them ? |
I've (hopefully) fixed the issue with the card shadows; and I've tried to modify the toggle buttons as well. The color issue is a bit more tedious, since we are using a version of Bootstrap served from a CDN. The only thing I could think of is manually overriding all the classes with the new colors, but at that point, I think it would be better to bump bootstrap to 5.3 which supports dark mode colors natively (unless anyone has better suggestions, of course). |
If the upgrade does not significantly affect the way the site is rendered, feel free to proceed with that 👍🏼 |
Apologies for the late PR. Please review and let me know if I missed any colors. |
Hey @shinwookim ! Thanks for the update. You changes are looking great on Firefox. Unfortunately, for some reason I don't see them reflecting on Chrome. See screenshots below: Could you look into why that is the case ? |
It should now be working in chrome! (Appears that chrome did not support the latest css features) |
Looks great now on Firefox and Chrome. Thanks much for your contribution! 🙂 |
Added dark mode support that: