Python 3 support for urlparse4#14
Conversation
| ], | ||
| long_description=long_description, | ||
| ext_modules=ext_modules, | ||
| include_package_data=True |
There was a problem hiding this comment.
is include_package_data=True removed on purpose?
There was a problem hiding this comment.
I remember I got some trouble with it at the beginning but now it's resolved. Let me put it back real quick!
| from urlparse import * | ||
| import six | ||
|
|
||
| from six.moves.urllib.parse import urlparse, urlsplit, urljoin |
There was a problem hiding this comment.
I think the idea behind from urlparse import * was to provide all functions from urlparse module, and then override some of them below, so this should be from six.moves.urllib.parse import * now
There was a problem hiding this comment.
I got this error when importing all the modules of urllib:
NameError: name 'urlsplit' is not defined
There was a problem hiding this comment.
Should I import all the functions in urllib manually?
| _original_urljoin = urljoin | ||
|
|
||
| from cgurl import urlsplit, urljoin | ||
| from cgurl import url_split, url_join |
There was a problem hiding this comment.
this functions should override urlsplit, urljoin from urlparse, so names should stay the same
There was a problem hiding this comment.
I had some ImportError before so I tried to change it as an experiment. I will put it back now 😄
Hey guys, I made a python 3 support for this project. Can you take a look at it when you have a chance? 😃 #5