-
Notifications
You must be signed in to change notification settings - Fork 0
JSON document store #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Gozala can one |
We could, although it does seem like a footgun as service will have to send a complete document every time anything in the document changes. I would personally recommend going with explicit paths first and expanding it if found necessary, but happy to go other way round if desired. |
|
Update document to be explicit about a question @anotherjesse asked. I proposed more conservative approach, but not to imply strong preference, happy to do update to the opposite if so desired. |
|
High-level, the most direct way to hook this up would be to implement https://github.com/commontoolsinc/labs/blob/main/typescript/packages/lookslike-high-level/src/storage-providers.ts, which matches this proposal, except that:
Other question: We previously talked about partitioning along collections/databases, and in estuary we'd at least want per-user partitions. Can we introduce that? Just a database id in the API I assume (which eventually can be a public key or so, but to the API it's opaque)? I think then we have technically enough to get into estuary. Let's get this up, and then discuss stronger guarantees after that. |
jsantell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the write up and itemizing the contracts and edge cases
|
Had a call with @seefeldb where we decided:
I'll update this document to reflect about decisions |
|
@bfollington would love to learn how this will need to evolve to support spellcaster requirements. |
One thing I expect we will care about soon is recently modified documents, perhaps we only need a most-recently-touched buffer for early prototyping but ultimately time series retrieval will be useful. |
You mean listing documents that have being modified since some timestamp or just having a timestamp for each document ? I’m inclined to say just put metadata needed on the document itself, it will inevitably evolve over time, but we can denotes some fields that we want to be indexed (although again I suspect we will end up realizing that we wanted this indexed and that indexed as time goes 😖) |
Never mind, lets just make timestamps special we can handle things in case by case basis. |
This would be after this first take, but one of the ways we can move to more robust consistency is via something event sourcing based, including from events that reflect what users did as closely as possible. That log could/should be linked with the meta data on the actual documents. Let's pick this up when you get to this need? |
📊 Preview