fix: charm reload on charm-list change #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
jumble/src/components/CharmRunner.tsx:132
- Verify that casting to 'Cell' aligns with the expected type for the render function, ensuring consistency with the updated type declarations in use.
const cleanup = render(container, charm.asSchema(charmSchema).key(UI) as Cell<VNode>);
|
|
||
| // Store a reference to the current charm to detect changes | ||
| const prevCharmRef = useRef(charm); | ||
| const prevCharmRef = useRef<Charm | null>(null); |
There was a problem hiding this comment.
Initializing prevCharmRef to null means the runtime error state will reset on the initial render; if preserving the initial charm state is required, consider initializing with the current charm value.
Suggested change
| const prevCharmRef = useRef<Charm | null>(null); | |
| const prevCharmRef = useRef<Charm | null>(charm); |
Contributor
|
LGTM |
anotherjesse
pushed a commit
that referenced
this pull request
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/common-tools/issue/CT-160/unexpected-refresh-on-charmsspaces-across-tabs by using charmId to track whether to re-render chram view or not.