-
Notifications
You must be signed in to change notification settings - Fork 7
Feat/schema improvements #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/schema improvements #1060
Conversation
support flash-lite
* Only re-render CharmList when connection status actually changes * Update types
import as FactModule instead of Fact to avoid collision expose the schema associated with the facts from QueryView make schemaContext optional in SchemaPathSelector, since I don't want to traverse commit logs Change default storage to cached
User Feedback UI - Implemented FeedbackActions and FeedbackDialog components in Jumble to allow users to submit positive or negative feedback on generated content. - Added interactive thumbs-up/down buttons with feedback form submission workflow. Trace Span ID Management - Added functions (setLastTraceSpanID, getLastTraceSpanID) to manage trace IDs in the builder environment. - Updated builder exports to expose new trace ID functions. Integration of Trace ID in LLM Client - Modified LLMClient to capture x-ct-llm-trace-id from response headers and store it via setLastTraceSpanID. Backend Feedback Handling - Extended toolshed API (/api/ai/llm/feedback) to accept user feedback and relay it to Phoenix observability backend. Instrumentation and Span Filtering - Enhanced OpenTelemetry instrumentation to include specific spans relevant to LLM inference requests for better observability.
…sk/return changed so the server sends each response to each subscriber, even though there may be duplicates. a schema subscription on the client needs to know its updated list of entities added lots of debugging to try to track down this stall issue
cleaned up logging and comments
This can be enabled by setting I ended up changing the query/graph/schema combination query and subscribe path to accept both the task/return and ongoing task/effect results. It doesn't unsubscribe when it gets the task/return. I also switched the subscription messages so they are dispatched to their caller, even if that means we send the same object more than once over the wire. The new I changed some of the machinery of traversing a document, but did not get around to changing the client traversal yet (nor did I make it synchronous, though it can be done that way now). There's some minor issues in charm.ts if we are trying to load the same document with multiple different schemas. We should be able to handle that and keep the different loads apart, but I don't think we actually use it, so I didn't spend more time on that. |
…tChannel available.
Here's an overview of the goal of this PR
https://linear.app/common-tools/issue/CT-179/maintain-schema-query-data-on-subscriptions#comment-a237dac2
I still have some issues I need to track down (mostly later).