chore: move bootstrap code into own script #1092
Conversation
a114687 to
c204df0
Compare
| @@ -104,6 +104,7 @@ | |||
| "merkle-reference": "npm:merkle-reference@^2.0.1", | |||
| "multiformats": "npm:multiformats@^13.3.2", | |||
| "react": "npm:react@^18.3.1", | |||
| "react-dom": "npm:react-dom@^18.3.1", | |||
There was a problem hiding this comment.
ℹ️ This is unfortunate addition here but without it deno compile seems to try and analyze bootstrap.js and complain about react-dom/client being imported. I was unable to find any other way to go around this
There was a problem hiding this comment.
Does using an HTTP URL for this in bootstrap.js work?
There was a problem hiding this comment.
It does but then we have two places where things are configured and can get out of sync, one will be here and other one will be at
labs/charm/src/iframe/static.ts
Lines 6 to 7 in d3f98bf
There was a problem hiding this comment.
I actually think we probably should bundle this modules instead of loading them from esm.sh but perhaps that is a task for another day
There was a problem hiding this comment.
They should resolve to the same module cache but who knows
| @@ -104,6 +104,7 @@ | |||
| "merkle-reference": "npm:merkle-reference@^2.0.1", | |||
| "multiformats": "npm:multiformats@^13.3.2", | |||
| "react": "npm:react@^18.3.1", | |||
| "react-dom": "npm:react-dom@^18.3.1", | |||
There was a problem hiding this comment.
This isn't ideal, will mean this may be included in the compiled artifact, but I understand why its here
Refactors sandbox bootstrap code into a separate js file so it's easier to iterate