Skip to content

fix: use preloaded data in useDoc #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

fix: use preloaded data in useDoc #1096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d780292
fix: use preloaded data in useDoc
Gozala Apr 23, 2025
cc972f1
Update jumble/public/module/charm/sandbox/bootstrap.js
Gozala Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions jumble/public/module/charm/sandbox/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ window.React = React
window.ReactDOM = ReactDOM
window.Babel = Babel

window.useDoc = function (key, defaultValue = null) {
window.useDoc = function (key) {
// Track if we've received a response from the parent
const [received, setReceived] = React.useState(false)
// Initialize state with defaultValue
Expand Down Expand Up @@ -44,18 +44,6 @@ window.useDoc = function (key, defaultValue = null) {
}
}, [key])

// After we've received a response, apply default value if needed
React.useEffect(() => {
if (received && doc === undefined && defaultValue !== undefined) {
// Only write the default value if we've confirmed no data exists
console.log("useDoc", key, "default", defaultValue)
window.parent.postMessage(
{ type: "write", data: [key, defaultValue] },
"*"
)
}
}, [received, doc, defaultValue, key])

// Update function
const updateDoc = newValue => {
if (typeof newValue === "function") {
Expand All @@ -66,11 +54,13 @@ window.useDoc = function (key, defaultValue = null) {
window.parent.postMessage({ type: "write", data: [key, newValue] }, "*")
}

// Return the current document value or the default if we haven't received data yet
return [
received ? (doc === undefined ? defaultValue : doc) : defaultValue,
updateDoc,
]
// If we have not yet received response from the host we use field from the
// sourceData which was preloaded via `subscribeToSource` during initialization
// in the `initializeApp`.
// ⚠️ Please note that value we prefetched still could be out of date because
// `*` subscription is removed in the iframe-ctx.ts file which could lead
// charm to make wrong conclusion and overwrite key.
return [received ? doc : window.sourceData[key], updateDoc]
}

// Define llm utility with React available
Expand Down