chore: Update Writable->Mutable and apply it recursively for queries. #1102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as JSONSchemarather thansatisfies JSONSchema, which was causing some type issuesWritable,Mutable, mostly noting distinctionsatisfies JSONSchemaclauses from @ubik2 Change some places where we declared a schema "as JSONSchema" #1103 (without whichSchemaresolves toany)Writabletype helper was not applying mutability recursively; an object with a string type would break out its properties, starting with:but typed as
With using a recursive version of the
Mutablehelper, the types now resolve to a query instance:While the email case is mostly readonly, and this is used as just an illustrative example (bgAdmin for example does need mutability), we do set
IDon aemailquery, a property ofJSONSchema, notSchema; this is failing types currently, not sure of the way forward here: