Cell recipes redux #1111
Cell recipes redux #1111
Conversation
woohoo - so close - existing works, but new fail more cleanup more wip
|
rebasing #1088 was complex, and so I want to keep it in its original state while I try to finish this branch |
|
it says all the tests are passing, but I know I ripped out module support when creating the new recipe manager either I didn't do as much damage as I thought. or more likely we don't have adequate coverage for it |
|
fyi: @bfollington @jsantell I had to tweak some of your recent changes to work with this patch |
once we start compiling, use a shared promise to send to anyone else asking for the compiled version
jumble/src/views/CharmDetailView.tsx
Outdated
| let argumentJson: Record<string, any>; | ||
| try { | ||
| if (isArgumentExpanded) { | ||
| argumentJson = translateCellsAndStreamsToPlainJSON( | ||
| charmManager.getArgument(charm).get(), | ||
| ) as Record<string, any>; | ||
| } else { | ||
| argumentJson = {}; | ||
| } | ||
| } catch (error) { | ||
| console.warn("Error translating argument to JSON:", error); | ||
| argumentJson = {}; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: wrapping in useMemo would be better again for render perf
There was a problem hiding this comment.
good idea - should we do it for this below as well:
value={translateCellsAndStreamsToPlainJSON(charm.get()) ?? {}}
I had moved it out of inline jsx because getArgument now throws (see above)
Edit commit to re-trigger actions
5049ccd to
7fc6bad
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Store the recipes in the space with the charms!
New recipeManager
runner/src/recipe-manager.tsOther changes: