Charmathon 2025-05-30 fixes #1126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses several issues outlined in CT-350 through CT-354 by updating API defaults, enhancing the useReactiveCell hook to support key paths, improving boolean tests for empty string values, and refining documentation.
- Update of default LLM models in llm/src/types.ts
- Refactor of useReactiveCell in bootstrap.js to accept key paths and adjustments in LLM response handling
- Improved check for plan description in charm/src/iterate.ts and documentation updates in charm/src/iframe/static.ts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| llm/src/types.ts | Changed default iframe model from "google:gemini-2.0-flash" to "openai:gpt-4.1-nano". |
| jumble/public/module/charm/sandbox/bootstrap.js | Refactored useReactiveCell to take key paths and updated LLM response handling in APIs. |
| charm/src/iterate.ts | Modified condition for plan description to accept empty strings as valid input. |
| charm/src/iframe/static.ts | Updated API documentation and examples to reflect the new useReactiveCell(keyPath: string[]). |
Comments suppressed due to low confidence (1)
jumble/public/module/charm/sandbox/bootstrap.js:133
- The removal of the '.then(result => result.content)' unwrap in generateText may result in inconsistent handling when the LLM returns a direct string and when it returns an object. Consider adding a conditional check to unwrap the .content property only when necessary.
window.generateText = function ({ system, messages }) {
| window.removeEventListener("message", handleMessage); | ||
| window.parent.postMessage({ type: "unsubscribe", data: [rootKey] }, "*"); | ||
| }; | ||
| }, [rootKey, nestedPath.join(".")]); // Dependency on stringified path |
There was a problem hiding this comment.
[nitpick] Using nestedPath.join(".") in the dependency array could be problematic if any key contains periods. Consider an alternative approach for dependency tracking that avoids potential collisions in key names.
Suggested change
| }, [rootKey, nestedPath.join(".")]); // Dependency on stringified path | |
| }, [rootKey, nestedPath]); // Dependency on array reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CT-350 CT-351 CT-352 CT-353 CT-354
TODO
.contentunwrapawaiting generateImage ->generateImageUrlIdeas