Skip to content

If all the charms in a space become disabled, stop the scheduler for that space. #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

If all the charms in a space become disabled, stop the scheduler for that space. #1194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
285717a
If all the charms in a space become disabled, stop the scheduler for …
ubik2 May 29, 2025
4c96042
catch errors in stop
ubik2 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/background-charm-service/src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,18 @@ export class BackgroundCharmService {
addCancel(scheduler.watch(didCharms));
}

const removedSpaces = new Set(this.charmSchedulers.keys()).difference(dids);
Copy link
Collaborator

@jsantell jsantell May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL Set.prototype.difference

Copy link
Contributor Author

@ubik2 ubik2 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, these functions are convenient. Particularly here, where the natural thing would be to modify the map as you walk through it, which can mess up your iterator.

for (const did of removedSpaces.values()) {
// we are no longer monitoring this space
const scheduler = this.charmSchedulers.get(did);
this.charmSchedulers.delete(did);
// we can't await this in our callback, but we can at least catch and log errors
scheduler?.stop().catch((e) =>
console.error(`Error stopping scheduler: ${e}`)
);
// TODO(@ubik2) I'm not sure if we need to call the cancel function returned by scheduler.watch
}

return cancel;
}
}