-
Notifications
You must be signed in to change notification settings - Fork 9
Refactor builder API into a factory + separate types for interface #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
44cc4d3
initial step of refactoring builder API to be created by a factory + …
seefeldb 8c4f7fa
deno.lock change, not sure this is right
seefeldb 2a712d9
let's just go back to `any` here, this is wonky
seefeldb 2ac3fe2
builder/interface.ts and builder/schema-to-ts.ts are now together ent…
seefeldb 27de921
lots of types fixes for previous change
seefeldb d8837ba
more type fixes
seefeldb 14b319b
remove this syntax for now
seefeldb 82ca353
remove extraneous parameter for createBuilder
seefeldb 9c614de
add back ability to set schema with cell/opaqueRef
seefeldb f2fe26a
fix more tests
seefeldb 79ef937
export opaqueRef directly still, for internal use outside of recipes
seefeldb 6074063
partially fix test
seefeldb c630bc1
import type with `type` annotation
seefeldb 6f97b4d
interface is now truly just the public interface. users should only i…
seefeldb d6398e3
separated imports in other places
seefeldb 4d9e789
fix misaligned exports
seefeldb f11897e
removed Mutable from interface
seefeldb 255a1cb
change all recipes to import from /interface.
seefeldb 70139fe
redo use of SchemaWithoutCell in the right places, this fixed the tests
seefeldb 0206774
need Mutable<> after all, so duplicating here to keep interface.ts an…
seefeldb fe6edc7
recipe also needs SchemaWithoutCell
seefeldb 65c14ca
and recipe needs that also for the recipe function!
seefeldb 1300446
fix recipes
seefeldb 2a226d6
move getRecipeEnvironment to public environment
seefeldb 5c4f4b7
revert to original deno.lock
seefeldb 2bb1e50
also exports constants via builder!
seefeldb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove extraneous parameter for createBuilder
- Loading branch information
commit 82ca353f3fe0abfd91754f542337e15656df45e5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.