Convert cell links to sigil values #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ad319d to
5c89a41
Compare
3f5ddc0 to
3386600
Compare
c4f5828 to
9ff542b
Compare
There was a problem hiding this comment.
cubic found 8 issues across 36 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
…rray schema generation - Add runtime parameter to createJsonSchema function to resolve sigil links - Replace legacy cell link handling with new sigil link parsing - Improve array schema generation to handle mixed object types with anyOf - Update tests to pass runtime parameter and expect new array schema format - Remove unused imports and simplify link resolution logic
…optional if they are always there for given combinations of inputs
…moving indirection of getLink.
- Update isSigilValue to require that the "/" property is a plain object (not an array), using isObject instead of isRecord. - Add a comprehensive test suite for isSigilValue, including: - Valid sigil values (with only "/" property as an object) - Cases where "/" and other properties coexist (should not be sigil) - Cases where "/" is not an object (string, number, array, null, etc.) - Non-object and edge cases - Ensures sigil value detection is robust and future-proof.
… link for now. This should be captured lower in the stack.
f806fb4 to
6d37fa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all places that expect
{ cell: DocImpl, path: ProperyKey[] }to also accept the JSON representation. Turns off that translation in storage.ts.At the same time, supports the new sigil for links, should be extracted, effectively
{ "/": { "link@1": { ... }}}). Folds aliases into those withoverwrite: "redirect"as flag.This is because today storage.ts translates any { "/": string } it finds to { "/": DocImpl }, but we don't want to carry this logic over to this new state.
This changes also affected schema queries on the serverside, which should also support both format.
For future PRs:
$alias) because there are a few hacks for closures that I didn't want to carry forward. There's an upcoming refactor here and after that we should change this.