Add transaction support to storage interface #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces IStorageTransaction with fork/commit/abort operations, consistency guarantees, and comprehensive error handling for transactional storage operations.
seefeldb
reviewed
Jun 19, 2025
seefeldb
reviewed
Jun 19, 2025
Gozala
commented
Jun 19, 2025
Gozala
commented
Jun 19, 2025
Gozala
commented
Jun 20, 2025
Gozala
commented
Jun 20, 2025
Gozala
commented
Jun 20, 2025
Gozala
commented
Jun 20, 2025
Gozala
commented
Jun 20, 2025
Gozala
commented
Jun 20, 2025
Gozala
commented
Jun 20, 2025
seefeldb
approved these changes
Jun 22, 2025
| }>; | ||
|
|
||
| export interface IStorageAddress { | ||
| the: The; |
Contributor
There was a problem hiding this comment.
(not blocking merging this PR)
I wonder whether we should align this with the sigil terms, starting to push these more common names further down the stack.
So type, source, path.
source is a bit odd for writes.
So second - more urgent - question: Should we go back to id in sigils? Make it (eventually) consistent throughout the codebase?
cc @ubik2 as well
Contributor
Author
There was a problem hiding this comment.
I suggest we leave this as is for now and when we update memory implementation we can update names here also.
Contributor
There was a problem hiding this comment.
I'd rather not have to change sigils again, since then we'll have data with the wrong names, hence that one being more urgent. Will break it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we only define an interface to be implemented in a followup change. Goal is to discuss and build a consensus around what the API should be like to support desired use cases.
Summary by cubic
Added a new transactional storage interface with support for starting, committing, and aborting transactions, along with detailed error handling and consistency guarantees. This defines the API only and does not include an implementation.