fix: incorporate cross space transaction API #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seefeldb
reviewed
Jun 23, 2025
seefeldb
approved these changes
Jun 23, 2025
seefeldb
reviewed
Jun 25, 2025
| } | ||
| export interface INotFoundError extends Error {} | ||
| export type IStorageTransactionProgress = Variant<{ | ||
| open: IStorageTransactionLog; |
There was a problem hiding this comment.
clarification: to entries move from open to pending to done?
if i want to know all, no matter the status (as scheduler needs it), should it iterate over all of them? who else is going to call this?
There was a problem hiding this comment.
Idea has being that they all contain same transaction log, it's just transaction itself is either open, pending or done. In the implementation I renamed open to edit to make it more clear that transaction is editable while when pending or done it's no longer editable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Added support for cross-space transactions in the storage interface, allowing transactions to read from multiple memory spaces and write to one.
readerandwritermethods for accessing different memory spaces within a transaction.