feat: memory transaction #1299
Merged
feat: memory transaction #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seefeldb
reviewed
Jun 26, 2025
packages/runner/src/storage/cache.ts
Outdated
| path.slice(0, at).join(".") | ||
| }" in "${address.space}", because target is not an object`, | ||
| ) | ||
| : new NotFound( |
There was a problem hiding this comment.
should this be a different error type?
or maybe add a field to the error that has an optional path that if the document did exist, it shows what part of the path matched (so the reader can use that as hint from where on the construct things)
Previously 3 subsequent changes could have raced if third change was made after we recieved confirmation for the 1st change but before receiving confirmation for the second one, leading to conflicts. Fix here evicts changes in nursery only if received state equals to local state in nurery closing window for the above race condition.
|
can we link to ticket in linear? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation draft of the transaction API.
Summary by cubic
Introduced a new memory transaction API that enables consistent, multi-space read and single-space write operations with commit and abort support.
IStorageManagerV2andIStorageTransactioninterfaces for transactional memory operations.