feat(link-utils): make parsed links complete memory addresses #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m memory addresses - Added a new `type` property to normalized link structures in `link-utils.ts`, defaulting to `application/json`. - Updated link parsing, normalization, and equality logic to handle the new `type` field. - Refactored related functions and tests to ensure correct handling and propagation of the `type` property. - Enhanced test cases in `link-utils.test.ts` to cover scenarios involving the `type` field and its default value.
Contributor
There was a problem hiding this comment.
cubic reviewed 3 files and found no issues. Review PR in cubic.dev.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a type field to all parsed links—defaulting to "application/json"—and updates parsing, normalization, equality checks, and tests accordingly.
- Introduces an optional
typeproperty onNormalizedLinkand enforcestypeinNormalizedFullLink. - Updates
parseLinkandareNormalizedLinksSameto handle the newtypefield. - Refactors and extends test suites to include the default
type.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/runner/src/link-utils.ts | Added type to link types, default value and equality logic, refactored NormalizedFullLink. |
| packages/runner/test/link-utils.test.ts | Extended tests to assert the default type in parsed links. |
| packages/runner/test/schema.test.ts | Updated schema tests to include the new type property. |
Comments suppressed due to low confidence (2)
packages/runner/src/link-utils.ts:39
- [nitpick] The doc comment is grammatically unclear. Consider rephrasing to: "Full normalized link from a complete link (with required id, space, and type), created by parseLink when a base is provided."
* Full normalized link that from a complete link, i.e. with required id, space
packages/runner/test/link-utils.test.ts:410
- [nitpick] Consider adding a test case that uses a non-default
typevalue and verifies thatareNormalizedLinksSamehandles differingtypefields correctly, to ensure full coverage of the new logic.
expect(result).toEqual({
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(link-utils): introduce
typefield for parsed links, making them memory addressestypeproperty to normalized link structures inlink-utils.ts, defaulting toapplication/json.typefield.typeproperty.link-utils.test.tsto cover scenarios involving thetypefield and its default value.Summary by cubic
Added a type field to parsed links in link-utils, making them complete memory addresses and defaulting to application/json.