Skip to content

fix: implement read support for data uris #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

fix: implement read support for data uris #1366

merged 3 commits into from
Jul 9, 2025

Conversation

@Gozala
Copy link
Contributor

@Gozala Gozala commented Jul 8, 2025 •
edited by cubic-dev-ai bot
Loading

Summary by cubic

Added support for reading data from data URI addresses, allowing inline data to be parsed and accessed like regular storage.

  • New Features
    • Recognizes and parses data URIs for JSON and text types.
    • Returns clear errors for invalid or unsupported data URIs.

ubik2
ubik2 reviewed Jul 8, 2025
View reviewed changes
jsantell
jsantell reviewed Jul 8, 2025
View reviewed changes
Gozala
Gozala commented Jul 8, 2025
View reviewed changes
@Gozala Gozala requested a review from jsantell July 8, 2025 21:49
seefeldb
seefeldb approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@seefeldb seefeldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but would be nice to throw unsupported media type when trying to write into a data: URI (sorry if I missed that, just did a quick scan)

@Gozala
fix: data uri write prevention (#1372)
3150bfa 
fix: Add read-only data URI write prevention
@Gozala
Copy link
Contributor Author

Gozala commented Jul 9, 2025

Lgtm, but would be nice to throw unsupported media type when trying to write into a data: URI (sorry if I missed that, just did a quick scan)

It was separate pr #1372

@Gozala Gozala merged commit e8c8cd8 into main Jul 9, 2025
7 checks passed
@Gozala Gozala deleted the feat/tx-data-uri branch July 9, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ubik2 ubik2 ubik2 left review comments

@seefeldb seefeldb seefeldb approved these changes

@jsantell jsantell Awaiting requested review from jsantell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gozala @jsantell @ubik2 @seefeldb