Ellyse/ct 580 gmail and rss importers have failures clean #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… detection in retry logic, cherrypick bernis change for handling for root writes with value property
|
reviewed with robin |
seefeldb
reviewed
Jul 16, 2025
| nextValue = | ||
| nextValue[key] = | ||
| (typeof Number(key) === "number" ? [] : {}) as typeof nextValue; | ||
| (!Number.isNaN(Number(key)) ? [] : {}) as typeof nextValue; |
There was a problem hiding this comment.
interesting, is this for clarity or did this misbehave?
if we change to Number., then let's use isInteger instead, since array indices have to be that.
There was a problem hiding this comment.
Number(key) might return NaN, however, typeof NaN is "number", so therefore its always true and it will never create an object. i guess thats why I used NaN since its closer probably to the intended behaviour. still, isInteger is better.
There was a problem hiding this comment.
Number will also cast string|number, where isInteger will always fail for strings, not sure of key type here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixed issues in Gmail and RSS importers by correcting array path handling and improving document creation logic.