Skip to content

Pushing some more tx changes to CharmManager For CT-612 #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Pushing some more tx changes to CharmManager For CT-612 #1431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions packages/charm/src/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,10 @@ export class CharmManager {
const newPinnedCharms = filterOutEntity(this.pinnedCharms, charmId);

if (newPinnedCharms.length !== this.pinnedCharms.get().length) {
this.pinnedCharms.set(newPinnedCharms);
const tx = this.runtime.edit();
const pinnedCharms = this.pinnedCharms.withTx(tx);
pinnedCharms.set(newPinnedCharms);
await tx.commit();
await this.runtime.idle();
return true;
}
Expand Down Expand Up @@ -243,7 +246,10 @@ export class CharmManager {

async emptyTrash() {
await this.syncCharms(this.trashedCharms);
this.trashedCharms.set([]);
const tx = this.runtime.edit();
const trashedCharms = this.trashedCharms.withTx(tx);
trashedCharms.set([]);
await tx.commit();
await this.runtime.idle();
return true;
}
Expand Down Expand Up @@ -861,13 +867,19 @@ export class CharmManager {

// Move to trash if not already there
if (!this.trashedCharms.get().some((c) => isSameEntity(c, id))) {
this.trashedCharms.push(charm);
const tx = this.runtime.edit();
const trashedCharms = this.trashedCharms.withTx(tx);
trashedCharms.push(charm);
await tx.commit();
}

// Remove from main list
const newCharms = filterOutEntity(this.charms, id);
if (newCharms.length !== this.charms.get().length) {
this.charms.set(newCharms);
const tx = this.runtime.edit();
const charms = this.charms.withTx(tx);
charms.set(newCharms);
await tx.commit();
await this.runtime.idle();
return true;
}
Expand All @@ -885,7 +897,9 @@ export class CharmManager {
// Remove from trash if present
const newTrashedCharms = filterOutEntity(this.trashedCharms, id);
if (newTrashedCharms.length !== this.trashedCharms.get().length) {
this.trashedCharms.set(newTrashedCharms);
const tx = this.runtime.edit();
this.trashedCharms.withTx(tx).set(newTrashedCharms);
tx.commit();
await this.runtime.idle();
return true;
}
Expand Down