feat(runner): Switch scheduler to new storage updates and reactive dependencies #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the reactive dependencies system to use a new storage notifications API instead of per-document update callbacks. The change improves efficiency by centralizing change handling and provides better path-based change detection.
- Replace document.updates() callbacks with centralized IStorageSubscription notifications
- Migrate from individual document subscriptions to unified change tracking via addresssesToPathByEntity()
- Update path comparison logic to use arraysOverlap() function for more accurate dependency matching
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/runner/test/schema.test.ts | Update import to use sortAndCompactPaths from reactive-dependencies |
| packages/runner/test/scheduler.test.ts | Remove compactifyPaths tests and update imports |
| packages/runner/test/reactive-dependencies.test.ts | Add comprehensive tests for new utility functions and edge cases |
| packages/runner/src/storage/interface.ts | Change MemoryAddressPathComponent from string | number to string only |
| packages/runner/src/scheduler.ts | Replace per-document callbacks with centralized storage subscription handling |
| packages/runner/src/reactive-dependencies.ts | Add new utility functions and improve path overlap detection |
| packages/runner/src/query-result-proxy.ts | Convert numeric indices to strings for path consistency |
There was a problem hiding this comment.
Function name has a typo: 'addresssesToPathByEntity' should be 'addressesToPathByEntity' (extra 's')
Suggested change
| addresssesToPathByEntity, | |
| addressesToPathByEntity, |
…ress Update sortAndCompactPaths to accept IMemorySpaceAddress objects instead of raw path arrays, enabling proper handling of space, id, and type metadata. Changes: - Update sortAndCompactPaths to work with IMemorySpaceAddress[] - Sort by space, id, type, then path for consistent ordering - Only compact paths within the same space/id/type combination - Add pathsToMapByEntity function to group addresses by space/id - Filter non-JSON types in pathsToMapByEntity - Update all tests to use IMemorySpaceAddress with proper URI/MediaType formats - Add comprehensive tests for pathsToMapByEntity function - Update benchmarks to test new sorting dimensions This enables the scheduler to properly track dependencies across different spaces and entities while maintaining efficient path compaction. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…than some triggering paths
e44e206 to
8049aa9
Compare
Contributor
There was a problem hiding this comment.
cubic analysis
1 issue found across 7 files • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
ubik2
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the scheduler to use the new storage notifications API instead of per-document update callbacks. This provides a more efficient and unified approach to tracking changes across the memory space.
Summary by cubic
Refactored the scheduler to use the new storage notifications API and updated reactive dependency tracking for better efficiency and accuracy across memory spaces.