feat(runner): implement await storage.synced() for new TX system #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the synced() method across the storage system to properly wait for all pending synchronization and commit operations to complete in the new transaction system.
- Add
synced()method to storage interfaces and implementations - Track commit promises in Replica to enable awaiting pending transactions
- Implement comprehensive sync waiting that covers both document syncs and transaction commits
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/runner/src/storage/interface.ts | Add synced() method signatures to IStorageManager and IStorageProvider interfaces |
| packages/runner/src/storage/cache.ts | Implement synced() functionality, track commit promises, and add getAllPromises() helper |
| packages/runner/src/storage.ts | Update Storage.synced() to use new implementation when not in shim mode |
packages/runner/src/storage/cache.ts
Outdated
There was a problem hiding this comment.
The type assertion as unknown as Promise<void> is unsafe and obscures the actual return type. Consider using void in the Promise.all() call or explicitly handling the array result.
Suggested change
| ]) as unknown as Promise<void>; | |
| ]).then(() => {}); |
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 3 files. Review in cubic
Add synced() method to wait for all pending syncs and commits to complete: - Add synced() to IStorageManager and IStorageProvider interfaces - Track commit promises in Replica to await pending transactions - Implement synced() in Provider to wait for both subscriptions and commits - Add getAllPromises() to SelectorTracker for subscription tracking - Update Storage.synced() to use new implementation when not in shim mode This ensures all pending operations complete before synced() resolves, including both document syncs and transaction commits.
2fc5ea6 to
68cb124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add synced() method to wait for all pending syncs and commits to complete:
This ensures all pending operations complete before synced() resolves, including both document syncs and transaction commits.
Summary by cubic
Added a synced() method to the storage system to ensure all pending syncs and transaction commits finish before continuing.