-
Notifications
You must be signed in to change notification settings - Fork 9
fix: update ct-outliner JSX types to match refactored component #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change $mentionable type from Cell<{"$NAME": string, "$UI": any}[]> to Cell<Charm[]>
to match how the component actually uses the NAME symbol
- Make children property optional in Child type since ct-outliner is self-closing
- Set oncharm-link-click to any to support handler proxy pattern
These changes fix type errors in recipes using ct-outliner after the
component refactor in commit 4e37bfb.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
without this change I'm getting: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic analysis
No issues found • Review in cubic
|
also you need a slight change to page.tsx: |
|
I've added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match how the component actually uses the NAME symbol
These changes fix type errors in recipes using ct-outliner after the component refactor in commit 4e37bfb.
🤖 Generated with Claude Code
Summary by cubic
Updated ct-outliner JSX types to match the refactored component and fix type errors in recipes.