first pass at running typescript recipes #171
Conversation
There was a problem hiding this comment.
this makes me want to put launch somewhere else... but it is probably too early
There was a problem hiding this comment.
we should probably treat it like any number of "built-ins", which we should move out of being hard coded in builder and available as packages to import, like many other reusable lifted functions and recipes. Let's do that this week, maybe when replacing generateData?
There was a problem hiding this comment.
we could for now at least change this string to be "@comontools/common-<...>"?
|
we should have better error handling on compilation failure |
There was a problem hiding this comment.
does the typescript compiler read the module definitions from somewhere? or just assumes broad types?
There was a problem hiding this comment.
nit, but adding a console variable in the scope around the eval doesn't work? (unless the code says window.console.log, but who does that :) )
There was a problem hiding this comment.
something analogous to updateValue doesn't work?
(we should discuss bidirectional bindings ....)
add a package.json command to compile the types
load them into the compiler
unaddressed:
- launch in data.js
- complain about {name} in recipe inputs
potentially dead end - but exploring generation
if compile, launch with data
|
Closing out stale PRs, please reopen if this is relevant |
No description provided.