chore(storage): log "already in history" and thus expected conflicts as info #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates conflict error handling to log "already in history" conflicts as informational messages rather than errors. The change modifies the condition that determines when conflicts should be treated as expected/informational.
- Changes the condition from checking
existsInHistoryto checking ifexpectedis null - Removes unnecessary line breaks in error message formatting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/runner/src/storage/cache.ts | Updates conflict detection logic to use expected == null condition |
| packages/memory/error.ts | Cleans up formatting by removing unnecessary line breaks in error message construction |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| result.error.conflict.existsInHistory | ||
| result.error.conflict.expected == null | ||
| ) { | ||
| logger.info(() => ["Transaction failed (aready exists)", result.error]); |
There was a problem hiding this comment.
There's a typo in the log message: 'aready' should be 'already'.
Suggested change
| logger.info(() => ["Transaction failed (aready exists)", result.error]); | |
| logger.info(() => ["Transaction failed (already exists)", result.error]); |
|
I had some confusion in discord, but perhaps this is viable. |
ubik2
requested changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Downgraded logging for expected “already exists” conflicts in storage to info by checking conflict.expected == null, reducing noisy error logs. Also cleaned up TheConflictError message formatting with no behavior change.