Check initializedUpTo to make sure it's not pointing past a reverted result. #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…result. - If we revert a result cell (or get some other server driven change), our closure captured initializedUpTo state will be out of sync. If this means it points after the last element, re-initialize the missing elements.
Contributor
Author
|
We re-run the opRecipe initialization in this revert scenario, which may already be running, but I think that's fine. |
ubik2
commented
Sep 18, 2025
| // .getRaw() because we want the recipe itself and avoid following the | ||
| // aliases in the recipe | ||
| const opRecipe = op.getRaw() as any; | ||
| const opRecipe = op.getRaw(); |
Contributor
Author
There was a problem hiding this comment.
Just removed unneeded cast here. op is already Cell<any>.
seefeldb
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Prevents the map builtin from reading past the result array after a rollback or server-driven change. We clamp initializedUpTo to the current length and re-init missing cells to keep results consistent.
Bug Fixes
Refactors