Ellyse/webread pattern #1825
Merged
Ellyse/webread pattern #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l in lift so that we dont have to call get()
bfollington
reviewed
Sep 25, 2025
Comment on lines
+92
to
+96
| const createPizzaListCell = lift<{ result: WebReadResult }, CheeseboardEntry[]>( | ||
| ({ result }) => { | ||
| return extractPizzas(result?.content ?? ""); | ||
| }, | ||
| ); |
Contributor
There was a problem hiding this comment.
RE: your comments on naming in standup, I find it a bit confusing to write create in a lifted function that is reactively bound like this, since it doesn't just run once. Maybe const pizzaList = toPizzaList({ result }) would be idiomatic (kinda FP inspired)?
Contributor
Author
There was a problem hiding this comment.
i sort of had that before. i felt like "cell" means it runs more than once, but i see that it could be confusing. hm honestly i sat on this a bit.
Contributor
Author
There was a problem hiding this comment.
toPizzaListLift? lol
bfollington
reviewed
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a new Cheeseboard pattern that fetches the pizza schedule via Toolshed’s web-read API and shows a simple date-and-pizza list in the UI. Parses the page content to extract daily pizza descriptions.