Remove Replica.push and change Provider.send to directly commit instead. #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/runner/src/storage/cache.ts">
<violation number="1" location="packages/runner/src/storage/cache.ts:1743">
Unreachable else branch due to duplicated condition, leaving dead code for label retraction.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| })); | ||
| } else { | ||
| changes.push({ of: uri, the: LABEL_TYPE }); | ||
| facts.push(retract(currentLabel as Consumer.Assertion)); |
Contributor
There was a problem hiding this comment.
Unreachable else branch due to duplicated condition, leaving dead code for label retraction.
Prompt for AI agents
Address the following comment on packages/runner/src/storage/cache.ts at line 1743:
<comment>Unreachable else branch due to duplicated condition, leaving dead code for label retraction.</comment>
<file context>
@@ -1790,29 +1717,37 @@ export class Provider implements IStorageProvider {
+ }));
} else {
- changes.push({ of: uri, the: LABEL_TYPE });
+ facts.push(retract(currentLabel as Consumer.Assertion));
}
}
</file context>
ubik2
added a commit
that referenced
this pull request
Sep 25, 2025
* Don't check subscriptions with read only transactions Some cleanup to avoid some of our complex nested classes. * Add a flag to Replica.push so that by default, we don't push transactions that are only Claims. * Alter transaction to prevent commit of nothing but claims. Add comment to Replica.push to note that we generally bypass that now (still used in tests and curl). * Remove Replica.push and change Provider.send to directly commit instead. (#1827)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Removed Replica.push and updated Provider.send to build facts and commit directly. This unifies the write path and removes redundant push logic.