Skip to content

Conversation

@ubik2
Copy link
Contributor

@ubik2 ubik2 commented Sep 30, 2025

Ignore this PR


Summary by cubic

Disabled the ban-types lint rule and removed related ignore comments in test fixtures to verify CI behavior without this rule.

  • Refactors
    • Disabled ban-types in deno.json.
    • Removed deno-lint-ignore ban-types comments in nested-default-optional fixture files.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@seefeldb
Copy link
Contributor

seefeldb commented Oct 1, 2025

@jsantell any final thoughts here? these also removes some other checks as we discussed, but I'm not sure anyone of us has ever run into that (e.g. using Number instead of number as type).

@jsantell
Copy link
Collaborator

jsantell commented Oct 1, 2025

@jsantell any final thoughts here? these also removes some other checks as we discussed, but I'm not sure anyone of us has ever run into that (e.g. using Number instead of number as type).

I dislike removal of any lint rule, but this is probably the only way to enable values as generic types while in a deno workspace

@ubik2
Copy link
Contributor Author

ubik2 commented Nov 3, 2025

I'm going to close this out for now. We can revisit it if we run into hurdles again in the schema-generator code, but there's no urgent need for a workaround, and we now know it works.

@ubik2 ubik2 closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants