Fix TypeScript errors after Deno upgrade to 2.5.2 #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deno 2.5.2 has stricter type checking for WebCrypto and Web APIs. Uint8Array now has a buffer property typed as ArrayBufferLike (ArrayBuffer | SharedArrayBuffer), but WebCrypto APIs require the stricter BufferSource type with ArrayBuffer specifically. Added explicit type casts to satisfy the stricter type requirements: - crypto.subtle.sign/verify/digest/importKey now require BufferSource casts - WebAuthn credential creation requires BufferSource casts for challenge and user.id - Response constructor requires BodyInit cast for Uint8Array bodies 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
I'm not sure casing in so many places it the right thing, but it also didn't feel obviously right to move that cast higher up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno 2.5.2 has stricter type checking for WebCrypto and Web APIs. Uint8Array now has a buffer property typed as ArrayBufferLike (ArrayBuffer | SharedArrayBuffer), but WebCrypto APIs require the stricter BufferSource type with ArrayBuffer specifically.
Added explicit type casts to satisfy the stricter type requirements:
🤖 Generated with Claude Code
Summary by cubic
Align WebCrypto, WebAuthn, and Response usage with Deno 2.5.2’s stricter types to fix TypeScript errors and restore builds.
Bug Fixes
Dependencies