chore: Parse identifiers for __ctHelpers usage rather than a naive string check #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathpirate
reviewed
Oct 10, 2025
|
|
||
| // Throws if `__ctHelpers` was found as an Identifier | ||
| // in the source code. | ||
| function checkCTHelperVar(source: string) { |
There was a problem hiding this comment.
nice, it's very cool that this is actually faster than the string check - i for sure would not have guessed that!
mathpirate
reviewed
Oct 10, 2025
| ); | ||
| } | ||
| } | ||
| return ts.visitEachChild(node, visitor, undefined); |
There was a problem hiding this comment.
claude suggests that you could consider using ts.forEachChild(node, visitor) just to avoid having the potentially confusing undefined third parameter for the TransformationContext. i think it's probably good to have it this way because we use visitEachChild elsewhere and it keeps us consistent, but, just mentioning
There was a problem hiding this comment.
I think forEachChild works as well, changing the return value to ts.Node | undefined, though the iteration logic seems different, but looking more into it (tests pass with it however)
mathpirate
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Detect the reserved __ctHelpers only when used as an identifier, instead of using a raw string check. This removes false positives from comments and similar names.